Merged
Conversation
also hashlib right away
datadog_lambda/wrapper.py
Outdated
| if not should_use_extension: | ||
| from datadog_lambda.metric import submit_invocations_metric | ||
|
|
||
| submit_invocations_metric(context) |
Contributor
There was a problem hiding this comment.
I don't think we want this change. You replaced an errors metric with an invocation metric. 😄
Contributor
Author
There was a problem hiding this comment.
Woops, thanks for catching that!
purple4reina
requested changes
Mar 28, 2025
Contributor
purple4reina
left a comment
purple4reina
left a comment
There was a problem hiding this comment.
The errors metric was changed into an invocation metric.
purple4reina
approved these changes
Mar 28, 2025
nhulston
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Lazy loads some imports for metrics and hashlib
Motivation
Metrics submission for invocations and errors doesn't need to be called if there's an extension active.
Hashlib import shouldn't occur unless the method for step functions is called.
Testing Guidelines
Tested manually
Before:
After:
Additional Notes
Types of Changes
Check all that apply